[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Basic support for checking NFSv4 ACLs in Linux

From: Bruno Haible
Subject: Re: [PATCH] Basic support for checking NFSv4 ACLs in Linux
Date: Fri, 25 Nov 2022 03:46:18 +0100

[CCing Andreas Grünbacher.]

Hi Ondrej,

Thank you very much for working on this, so consistently for a month.
Like you said: "it might not be perfect, but it's far better than what we
have now in there (i.e. nothing)". Therefore I'd like to have your changes
included, for the benefit of coreutils and of other programs that use the
Gnulib 'copy-file' module.

My question regarding the big picture has been answered by
so I'm OK to have this code in Gnulib now.

Your changes are more than 60 lines of code; that is legally relevant for
copyright purposes. GNU Gnulib (like GNU coreutils) requires a copyright
assignment to the FSF. I'll write to you separately about that.

Then, the code would need to be reformatted to use similar indentation
and coding style as the rest of Gnulib:
  - Untabify (spaces instead of tabs),
  - Indent by 2 spaces, with braces of compound statements going to
    separate lines,
  - Use separate lines in
         if (condition)
  - Use space before opening parenthesis in a function call.
  - Use line breaks to limit line length to 80, if possible.
  See <https://www.gnu.org/prep/standards/html_node/Formatting.html>

And finally, it would be useful if you could add a new file
doc/acl-nfsv4.txt where you describe the environment and commands
which should be used to verify that other contributors (in the future)
don't introduce regressions in your new code. This is as long as we
don't have automated unit tests (like tests/test-file-has-acl.sh,
tests/test-set-mode-acl.sh, tests/test-copy-acl.sh). Similar to what
you did for <https://bugzilla.redhat.com/show_bug.cgi?id=2136452>.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]