[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] selinux-h: add stubs for selabel_open etc.

From: Kamil Dudka
Subject: Re: [PATCH] selinux-h: add stubs for selabel_open etc.
Date: Sun, 22 Nov 2020 13:28:47 +0100

On Sunday, November 22, 2020 3:45:22 AM CET Paul Eggert wrote:
> Yes, it's looking like great minds think alike.
> The coreutils patch I had prepared is fancier than yours, though, as it
> caches the result of selabel_open and this should yield better performance.
> I don't use SELinux either. From the look of the coreutils source it appears
> that the coreutils SELinux code has some issues (multiple FIXMEs and some
> other questionable stuff). I fixed one or two of the problems I found, but
> it would be better if someone who cares about SELinux would audit the
> coreutils SELinux code more carefully, as I'm pretty sure there are bugs in
> there, at least with respect to diagnostics that are not issued when they
> should be. Also, the attached patches could have introduced some bugs on
> SELinux.
> At least these patches (which I just installed into coreutils) fix the
> broken build on Ubuntu 20.10 (also, on Solaris 10, which I found while
> doing a porting test of all this stuff).

The coreutils patch introduced tab-indented lines into src/mv.c, which 
otherwise does not use tabs for indentation.  I can see 3 tests failing
on Fedora 32, which seems to be related.  My test-suite.log is attached.


Attachment: test-suite.log.gz
Description: application/gzip

reply via email to

[Prev in Thread] Current Thread [Next in Thread]