[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: hash, xhash: modernize
From: |
Bruno Haible |
Subject: |
Re: hash, xhash: modernize |
Date: |
Sat, 17 Oct 2020 04:32:00 +0200 |
User-agent: |
KMail/5.1.3 (Linux/4.4.0-189-generic; KDE/5.18.0; x86_64; ; ) |
Hi Jim,
> > I tried to make it clear the last time we discussed this (long ago!)
> > that I prefer to keep certain comments very near the function
> > definition (and implementation).
Yes, I sort of remembered this. Therefore I asked for objections, and put
you in CC.
> > I disagree with the premise that hash_delete should be renamed. That's
> > an API-breaking change.
Yes, it's an API change. I applied the usual procedure for API changes in
gnulib: add the new API, then wait for more than a year, before the old API
can be removed.
> That said, I will not object to your normalizing diffs.
I'm confused now. Which of the three patches, or which parts of them,
do you wish to see reverted?
Bruno