bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] stat: implement GetFileInformationByHandle with Winstore app


From: Steve Lhomme
Subject: Re: [PATCH] stat: implement GetFileInformationByHandle with Winstore apps restrictions
Date: Sat, 30 May 2020 18:37:52 +0200 (CEST)

> On May 30, 2020 5:47 PM Bruno Haible <bruno@clisp.org> wrote:
> 
>  
> Steve Lhomme wrote:
> > > > You can see one of the last commit is adding 
> > > > GetFileInformationByHandle() for example. But that means anyone 
> > > > building with an older version of winstorecompat cannot rely on this 
> > > > helper.
> > > 
> > > That's not a good enough reason for adding this code to gnulib.
> > 
> > I agree. But there should be a way to compile gnulib without calling the 
> > forbidden/old/deprecated API's. That's currently not possible. For example 
> > in stat-w32.c the "_GL_WINDOWS_STAT_INODES == 2" mode is not enabled yet. 
> > And even then it would still do a call GetFileInformationByHandle() which 
> > will not link in the end. (in mingw-w64 it will because they don't builds 
> > libs for UWP/not-UWP)
> 
> It should link fine if you use the 'winstorecompat' library that you 
> mentioned.
> If it doesn't, it's a problem with that library, not with Gnulib.

It wouldn't until a few days ago before I patched it. Anyone using mingw 7.0 
(ie all current Linux distros) will not be able to use it until there's a 
release.

And this library exists for legacy code that cannot be changed. I don't think 
gnulib falls in this category. And ultimately that library should not be used 
at all.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]