[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: pure and const function attributes
From: |
Bruno Haible |
Subject: |
Re: pure and const function attributes |
Date: |
Sat, 02 May 2020 10:14:14 +0200 |
User-agent: |
KMail/5.1.3 (Linux/4.4.0-177-generic; KDE/5.18.0; x86_64; ; ) |
Hi Paul,
> into the attached patch.
Looks good overall. Just a few small remarks:
1)
> +#ifndef _GL_ATTRIBUTE_GCC_GL_H
> +#define _GL_ATTRIBUTE_GCC_GL_H
> +#ifndef _GL_ATTRIBUTE_GCC_H
> +#define _GL_ATTRIBUTE_GCC_H
Why not align the double-inclusion guard macros with the file names
(which don't have 'gcc' in them)?
2) In lib/attribute.h, you didn't #include "attribute-gl.h". Therefore
the right place for the macros in attribute-gl.h seems to be
m4/gnulib-common.m4. So far, we have put the _GL_* macros there because
- they are extremely unlikely to clash with symbols from other packages,
- it's annoying to have to add not only #include <config.h> but also
#include <attribute-gl.h> to so many header files.
3) In modules/attribute, you reference m4/attribute.m4. Where is this file?
Bruno