bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: gl_{,SN}PRINTF_DIRECTIVE_N wrongly fail on Ubuntu 18.04


From: Bruno Haible
Subject: Re: gl_{,SN}PRINTF_DIRECTIVE_N wrongly fail on Ubuntu 18.04
Date: Mon, 16 Mar 2020 14:17:44 +0100
User-agent: KMail/5.1.3 (Linux/4.4.0-174-generic; KDE/5.18.0; x86_64; ; )

I wrote:
> 2020-03-08  Bruno Haible  <address@hidden>
> 
>       *printf-posix: Document why it's overridden on some glibc systems.
>       Reported by Adrian Bunk <address@hidden> in
>       <https://lists.gnu.org/archive/html/bug-gnulib/2020-03/msg00011.html>.
>       * doc/posix-functions/*printf.texi: Document the problem with the %n
>       directive on some glibc systems.
>       * m4/printf.m4 (gl_PRINTF_DIRECTIVE_N, gl_SNPRINTF_DIRECTIVE_N): Adjust
>       the cross-compilation guesses accordingly.

Oops, this patch had a mistake: It produced an error

executing aclocal -I glm4
/usr/bin/m4:configure.ac:4472: recursion limit of 1024 exceeded, use -L<N> to 
change it
autom4te: /usr/bin/m4 failed with exit status: 1
aclocal: error: echo failed with exit status: 1

Caught by the continuous integration - thanks Tim for setting it up!


2020-03-16  Bruno Haible  <address@hidden>

        *printf-posix: Fix m4 error (regression from 2020-03-08).
        * m4/printf.m4 (gl_SNPRINTF_DIRECTIVE_N): Enable interpretation of
        brackets in AC_COMPILE_IFELSE invocation.

diff --git a/m4/printf.m4 b/m4/printf.m4
index 54a2d71..df473d8 100644
--- a/m4/printf.m4
+++ b/m4/printf.m4
@@ -1,4 +1,4 @@
-# printf.m4 serial 63
+# printf.m4 serial 64
 dnl Copyright (C) 2003, 2007-2020 Free Software Foundation, Inc.
 dnl This file is free software; the Free Software Foundation
 dnl gives unlimited permission to copy and/or distribute it,
@@ -1422,7 +1422,6 @@ int main ()
         [gl_cv_func_snprintf_directive_n=yes],
         [gl_cv_func_snprintf_directive_n=no],
         [
-changequote(,)dnl
          case "$host_os" in
                                  # Guess no on glibc when _FORTIFY_SOURCE >= 2.
            *-gnu* | gnu*)        AC_COMPILE_IFELSE(
@@ -1434,6 +1433,7 @@ changequote(,)dnl
                                    [gl_cv_func_snprintf_directive_n="guessing 
yes"],
                                    [gl_cv_func_snprintf_directive_n="guessing 
no"])
                                  ;;
+changequote(,)dnl
                                  # Guess yes on musl systems.
            *-musl*)              gl_cv_func_snprintf_directive_n="guessing 
yes";;
                                  # Guess yes on FreeBSD >= 5.
@@ -1466,8 +1466,8 @@ changequote(,)dnl
            mingw*)               gl_cv_func_snprintf_directive_n="guessing 
no";;
                                  # If we don't know, obey 
--enable-cross-guesses.
            *)                    
gl_cv_func_snprintf_directive_n="$gl_cross_guess_normal";;
-         esac
 changequote([,])dnl
+         esac
         ])
     ])
 ])




reply via email to

[Prev in Thread] Current Thread [Next in Thread]