[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: fstrcmp: memory is not reclaimed on exit

From: Paul Eggert
Subject: Re: fstrcmp: memory is not reclaimed on exit
Date: Sun, 16 Feb 2020 13:59:37 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1

On 2/16/20 12:44 PM, Jeffrey Walton wrote:
The coding standard is wrong in this area. The practice breaks testing.

Not really. It breaks some tests, which are arguably testing the wrong thing. Any tests that check for whether all memory is freed just before exit, are testing for a property that the GNU Coding Standards say is not a desirable property.

The underlying issue is whether we should complicate code to simplify tests, or vice versa. The GCS say that in this area we should keep the code simple, possibly at the expense of the tests. This is not inherently the wrong decision; it's merely choosing a point in a design space that involves simplicity, efficiency, correctness, testability, etc. and where there are several reasonable choices.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]