[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fwd: GnuTLS 3.6.12 patch for OS X 10.9

From: Paul Eggert
Subject: Re: Fwd: GnuTLS 3.6.12 patch for OS X 10.9
Date: Mon, 3 Feb 2020 18:32:02 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1

On 2/3/20 3:00 PM, Jeffrey Walton wrote:

Or, you can use __has_attribute(_Noreturn). __has_attribute(_Noreturn)
behaves as expected.

It isn't documented to work, and it doesn't work for me with clang version 9.0.0 (Fedora 9.0.0-1.fc31).

I would not worry about other software using __has_attribute. It is a
reserved symbol due to the leading undersocres. Userland software
should not have been using it in the first place.

Gnulib is userland software, so we cannot use your argument to justify putting "#define __has_attribute(x) 0" into Gnulib.

How about the attached (untested) patch instead? It looks at __apple_build_version__.

PS. I must say that Apple's hijacking and renumbering of __clang_major__ seems pretty antisocial, and breaks some already-existing code in Gnulib - what caused Apple to do that?

Attachment: 0001-Port-_Noreturn-to-older-Clang.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]