bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patch] glob. If pattern has a trailing slash match directories only


From: Bruno Haible
Subject: Re: [patch] glob. If pattern has a trailing slash match directories only
Date: Sun, 10 Nov 2019 01:55:32 +0100
User-agent: KMail/5.1.3 (Linux/4.4.0-166-generic; KDE/5.18.0; x86_64; ; )

Hi Dmitry,

> The original version of this patch was discussed here
> https://sourceware.org/ml/libc-alpha/2017-11/msg00983.html.

When I read this mail thread, the status was that not all issues raised
by Paul were resolved, in particular the performance regression. Are
these issues supposed to be fixed in the new patch?

Remarks about the tests (I appreciate that you add tests!):
  - Please follow GNU coding style, esp. regarding space between a function
    name and its arguments:
      int rc = symlink (old, new);
  - Similarly, add spaces around operators:
      GLOB_MARK | GLOB_ONLYDIR
  - The functions touch, md, ln, ln_s all return 0; better change the return
    type to 'void'.
  - Why is 'verbose' an 'int'? Couldn't it be a 'bool'?

Bruno




reply via email to

[Prev in Thread] Current Thread [Next in Thread]