bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 2/2] maint.mk: Replace grep with $(GREP)


From: Roman Bolshakov
Subject: Re: [PATCH v2 2/2] maint.mk: Replace grep with $(GREP)
Date: Wed, 5 Dec 2018 15:16:33 +0300
User-agent: NeoMutt/20180716

On Tue, Dec 04, 2018 at 04:14:04PM -0600, Eric Blake wrote:
> On 12/3/18 9:00 AM, Roman Bolshakov wrote:
> >      : Filter by file name;                                         \
> >      if test -n "$$in_files"; then                                  \
> > -     files=$$(find $(srcdir) | grep -E "$$in_files"                        
> > \
> > -              | grep -Ev '$(_sc_excl)');                           \
> > +     files=$$(find $(srcdir) | $(GREP) -E "$$in_files"                     
> > \
> > +              | $(GREP) -Ev '$(_sc_excl)');                                
> > \
> >      else                                                                   
> > \
> 
> My email is showing ragged \, but that may be a result of TAB indentation
> combined with prefix characters from both the patch format and my email
> reply quoting mechanism.  Hopefully, with the patch applied, you are still
> trying to keep \ aligned rather than letting them go ragged (that is, a
> blind search-and-replace breaks formatting, so I hope you touched things up
> manually afterwards).

Hi Eric,

Yes, I manually aligned backslashes with TABs after replacing grep with
$(GREP). No blind replacment took place :)

Thanks,
Roman



reply via email to

[Prev in Thread] Current Thread [Next in Thread]