[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4] Ensure mktime sets errno on error (bug 23789)
From: |
Bruno Haible |
Subject: |
Re: [PATCH v4] Ensure mktime sets errno on error (bug 23789) |
Date: |
Sat, 10 Nov 2018 03:50:36 +0100 |
User-agent: |
KMail/5.1.3 (Linux/4.4.0-138-generic; KDE/5.18.0; x86_64; ; ) |
Hi Paul,
0007-mktime-DEBUG_MKTIME-cleanup.txt
> + The DEBUG_MKTIME code no longer works in glibc or in Gnulib.
> + And it’s no longer needed now that glibc and Gnulib both have
> + their own testing mechanisms for mktime.
What do you mean? I don't see an 'mktime-tests' module, nor a 'timegm-tests'
module, not a 'localtime-tests' module in gnulib. Gnulib has some tests
whether the system's mktime() has certain bugs, but no verification that the
replacement code actually fixes these bugs, nor any other unit test.
Bruno
- Re: [PATCH v4] Ensure mktime sets errno on error (bug 23789), Paul Eggert, 2018/11/02
- Re: [PATCH v4] Ensure mktime sets errno on error (bug 23789), Paul Eggert, 2018/11/05
- Re: [PATCH v4] Ensure mktime sets errno on error (bug 23789), Albert ARIBAUD, 2018/11/06
- Re: [PATCH v4] Ensure mktime sets errno on error (bug 23789), Albert ARIBAUD, 2018/11/06
- Re: [PATCH v4] Ensure mktime sets errno on error (bug 23789), Paul Eggert, 2018/11/06
- Re: [PATCH v4] Ensure mktime sets errno on error (bug 23789), Albert ARIBAUD, 2018/11/07
- Re: [PATCH v4] Ensure mktime sets errno on error (bug 23789), Albert ARIBAUD, 2018/11/07
- Re: [PATCH v4] Ensure mktime sets errno on error (bug 23789), Paul Eggert, 2018/11/09
- Re: [PATCH v4] Ensure mktime sets errno on error (bug 23789),
Bruno Haible <=
- Re: [PATCH v4] Ensure mktime sets errno on error (bug 23789), Paul Eggert, 2018/11/09
- Re: [PATCH v4] Ensure mktime sets errno on error (bug 23789), Albert ARIBAUD, 2018/11/13
- Re: [PATCH v4] Ensure mktime sets errno on error (bug 23789), Albert ARIBAUD, 2018/11/13