[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [bug #33724] Find command is changing the access time of directory
|
From: |
Bernhard Voelker |
|
Subject: |
Re: [bug #33724] Find command is changing the access time of directory |
|
Date: |
Sun, 30 Sep 2018 09:00:29 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 9/30/18 2:01 AM, Paul Eggert wrote:
> Bernhard Voelker wrote:
>> a) rename FTS_NOATIME to FTS_NOATIME, and add a retry to open/openat
>> in each place when that was using O_NOATIME and we got EPERM.
>
> I didn't quite get the point of the rename; those two identifiers look
> identical
> to me.
>
> The original commit said that FTS_NOATIME was intended to be best effort, and
> that FTS_NOATIME would be ineffective in some cases. If that's the intent,
> retrying would implement it.
Drats, yes, I meant "rename from FTS_NOATIME to FTS_TRY_NOATIME [...]", sorry.
My idea in a) was to make it clearer to the gnulib user that FTS is just
trying at its best to use O_NOATIME, i.e, it can not and will not ensure
that _O_NOATIME is applied.
Have a nice day,
Berny