Re: [PATCH 5/6] fts: three levels of leaf optimization

[Bernhard Voelker]

On 04/11/2018 09:53 PM, Paul Eggert wrote:
> @@ -1589,6 +1593,15 @@ mem1:                           saved_errno = errno;
>                          tail->fts_link = p;
>                          tail = p;
>                  }
> +
> +                /* If there are many entries, no sorting function has been
> +                   specified, and this file system is of a type that may be
> +                   slow with a large number of entries, arrange to sort the
> +                   directory entries on increasing inode numbers.  */
> +                if (nitems == _FTS_INODE_SORT_DIR_ENTRIES_THRESHOLD
______________________________^^
> +                    && !sp->fts_compar)
> +                  sort_by_inode = dirent_inode_sort_may_be_useful (cur, 
> dir_fd);
> +

This looks wrong: didn't you mean the '>' operator?
Thanks for digging into this issue.

Have a nice day,
Berny