Re: fseeko broken by Fedora rawhide glibc / git master (ie future 2.28)

[Richard W.M. Jones]

On Wed, Mar 07, 2018 at 03:23:10PM +0000, Daniel P. Berrangé wrote:
> On Wed, Mar 07, 2018 at 09:05:59AM -0600, Eric Blake wrote:
> > On 03/05/2018 01:25 PM, Paul Eggert wrote:
> > > On 03/05/2018 11:20 AM, Daniel P. Berrangé wrote:
> > > > Yes, this worked on rawhide when I tested with libvirt.
> > > 
> > > Thanks, I installed it into Gnulib since it was breaking builds. Bruno's
> > > the expert here, and perhaps he can come up with something better.
> > 
> > It looks like Rich is hitting a similar problem when trying to test gnulib
> > on RISC-V:
> > 
> > https://fedorapeople.org/groups/risc-v/logs/lbzip2-2.5-8.fc27.src.rpm/build.log
> > 
> > 
> > gcc -DHAVE_CONFIG_H -I.     -O2 -g -pipe -Wall -Werror=format-security
> > -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions
> > -fstack-protector-strong -grecord-gcc-switches
> > -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1  -c -o printf-args.o
> > printf-args.c
> > fseterr.c: In function 'fseterr':
> > fseterr.c:77:3: error: #error "Please port gnulib fseterr.c to your
> > platform! Look at the definitions of ferror and clearerr on your system,
> > then report this to bug-gnulib."
> >   #error "Please port gnulib fseterr.c to your platform! Look at the
> > definitions of ferror and clearerr on your system, then report this to
> > bug-gnulib."
> >    ^~~~~
> > make[3]: *** [Makefile:1474: fseterr.o] Error 1
> > 
> > where I suspect the real problem is that the glibc header changes have
> > interfered with what fseterr.c used to rely on.
> 
> Yes, that's the exact same problem (_IO_ftrylockfile is no longer
> defined because libio.h went away). The solution Paul did in
> 
>   commit 4af4a4a71827c0bc5e0ec67af23edef4f15cee8e
>   Author: Paul Eggert <address@hidden>
>   Date:   Mon Mar 5 10:56:29 2018 -0800
> 
>     fflush: adjust to glibc 2.28 libio.h removal
> 
> should fix/workaround that, as it covers fseterr.c.

Thanks, that explains why the error didn't seem to have anything
to do with RISC-V :-)

FWIW I am currently (and very ... very ... slowly) running the whole
gnulib test suite on the platform.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://people.redhat.com/~rjones/virt-df/