[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: pygnulib: Portability fixes
From: |
Dmitry Selyutin |
Subject: |
Re: pygnulib: Portability fixes |
Date: |
Mon, 25 Sep 2017 23:30:41 +0300 |
Hi Mathieu,
thank you for submitting it.
> Here is a patch that removes the use of 'enum.Flags' that didn't exist
> until python 3.6. It seems that 'enum' classes are not well supported
> with older version too. So it seems more reasonable to not use them at
> all.
Wow, that's a surprise. Sure, we must support all Python 3 versions. Thank
you, I've applied it. Please check if everything is OK, I'm not a Git guru:
since parser and config were a bit ahead, I did the same as you did,
committed, then exported a patch via $(git format-patch HEAD~1), then put the
original author and text (only lowercasing a one letter). Please let me know
if you know a better way, I don't use Git intensively.
> I suppose that in the context of Gnulib it is important to be compatible
with Python 2?
It is not. :-) Even in 2012 when I started the original work, Bruno wanted to
stick to Python 3, but I still did everything in a crazy mix of both versions.
Now the support for Python 2 seems to be redundant; hopefully most Unices
either have Python 3 by default or at least have it in repositories, ports,
etc. The cost of maintaining the script for both versions is really huge, I
really think that Bruno was right from the very beginning.
--
With best regards,
Dmitry Selyutin
signature.asc
Description: This is a digitally signed message part.