bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] parse-datetime: use labs for long int


From: Rüdiger Meier
Subject: Re: [PATCH] parse-datetime: use labs for long int
Date: Sat, 22 Apr 2017 17:35:01 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0

On 04/22/2017 11:18 AM, Paul Eggert wrote:
Thanks for the heads-up. That code has long been on my list of things to
clean up, and your message prompted me to go about it. I installed the
attached, which fixes the runtime problem corresponding to the
diagnostic you mentioned, along with a lot of other problems. Please
give it a try.

Thanks a lot, I've reviewed your patch a bit and it looks good. But I can't test my particular case before next week or so.

I hope that your clang is smart enough not to complain
about expressions like abs (x % 60) merely because x's data type is
wider than int.

The compiler would still warn about "abs( ((long)x) % 60 )" but actually I can't find any place anymore in the new code where x is a long. So all should be fine now.

cu,
Rudi



reply via email to

[Prev in Thread] Current Thread [Next in Thread]