[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnulib-tool: new option --gnu-make
From: |
Bruno Haible |
Subject: |
Re: [PATCH] gnulib-tool: new option --gnu-make |
Date: |
Mon, 13 Mar 2017 10:07:10 +0100 |
User-agent: |
KMail/5.1.3 (Linux/4.4.0-66-generic; KDE/5.18.0; x86_64; ; ) |
Hi Paul,
> This is for applications like GNU Emacs that use GNU Make
> features instead of Automake.
Wow! A big change done with so little code. Kudos!
Do we need to revisit the Makefile.am section of all modules/* files?
Are there anti-patterns that should not be used in modules files when
a module should be usable with GNU Make instead of Automake?
> + sed "$convert_to_gnu_make" "$tmp"/amsnippet1
As a matter of style, I prefer to write
sed -e "$convert_to_gnu_make" "$tmp"/amsnippet1
as it conveys the information which argument has which role, and as
the -e option is mandatory anyway when you use sed inside a pipe.
Bruno