Re: [PATCH v2 0/4] New getprogname module

[Pino Toscano]

On Saturday, 3 September 2016 20:47:15 CEST Jim Meyering wrote:
> On Thu, Aug 18, 2016 at 6:18 AM, Pino Toscano <address@hidden> wrote:
> > as discussed in [1], this series adds a new getprogname module.
> > All it does is providing a getprogname function, much like what is
> > found on e.g. *BSD systems, and using it in gnulib instead of progname.
> > Also, using it explicitly by modules avoids gnulib users the need of
> > either use the progname module (GPL), or to provide program_name (and
> > call set_program_name manually, which is not always doable).
> >
> > Caveat: the progname is left as it is, so set_program_name will still
> > affect program_name but not what error will use.
> >
> > (Please note it's my first big patch to gnulib, so bear with me for
> > anything wrong/missing.)
> >
> > [1] http://lists.gnu.org/archive/html/bug-gnulib/2016-03/msg00048.html
>
> Thanks for your patience.

Thanks for the review, Jim.

> I amended the first commit to do this:
>
>   * MODULES.html.sh (Misc): Add getprogname.
>
> Two things were mistakenly removed. I have restored them:
>
> * lib/argmatch.c: Do not elide this comment:
>
>   /*
>    * Based on "getversion.c" by David MacKenzie <address@hidden>
>    */
>
> * modules/argmatch (Depends-on): Do not remove getprogname.

Sorry for the small issues in the patches -- your amendments look fine
to me.

Another thing: should some deprecation warning/note be added regarding
the progname module? Is NEWS the proper place for them? Attached there
is a small documentation addendum.

> I'm prepared to push the attached, but will wait for your ack.

ACK.

Thanks,
--
Pino Toscano

0001-Deprecate-the-progname-module.patch
Description: Text Data

signature.asc
Description: This is a digitally signed message part.