bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: suggested feature: "date --debug" - print date parsing diagnostics


From: Pádraig Brady
Subject: Re: suggested feature: "date --debug" - print date parsing diagnostics
Date: Fri, 12 Aug 2016 09:37:25 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0

On 12/08/16 04:38, Assaf Gordon wrote:
>> On Aug 10, 2016, at 05:59, Pádraig Brady <address@hidden> wrote:
>>
>> Those look good to squash and apply,
>> modulo s/setftime/strftime/ in modules/parse-datetime
> 
> Thank you for the review.
> Attached a squashed patch.
> I kept the name of the new function as 'parse_datetime2' (if that's 
> acceptable).

There's precedent for .....2() versions of functions, like renameat2() etc.
How about we pass an unsigned int flags, instead of bool, in case we ever
need to extend in future?






reply via email to

[Prev in Thread] Current Thread [Next in Thread]