[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/4] maint.mk: speed up po_check
From: |
Ján Tomko |
Subject: |
Re: [PATCH 1/4] maint.mk: speed up po_check |
Date: |
Mon, 1 Aug 2016 13:48:56 +0200 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Fri, Jul 29, 2016 at 10:52:00PM -0700, Jim Meyering wrote:
On Tue, Jul 26, 2016 at 7:28 AM, Ján Tomko <address@hidden> wrote:
+2016-07-26 Ján Tomko <address@hidden>
+
+ maint.mk: speed up po_check
+
+ There is some logic in sc_po_check that skips files based on their
+ names, or existence of files with derived names.
+
+ Rewrite it in perl instead of shell to make the check faster.
Thank you!
Nice change.
I've adjusted your patch and ChangeLog slightly:
- removed unnecessary $$ret=0
- I prefer to use (and the rest of the file uses) TABs for
right-margin "\" alignment
- I've adjusted the perl for style, and improved the
.[ly]-existence-checking section
With that, elapsed time for "make sc_po_check" in libvirt goes from
96s to just 16s.
The best case in libvirt went from 2.7s to 0.26s (9.42% of the original time)
on my laptop with i7-5600U @ 2.6 GHz.
I'll be happy to push the attached diff or something close, but will
wait a bit, in case there's something else to improve.
From e25cdc9a4f9ac24ace0dbc1ab4fc84ca6a13efd6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=C3=A1n=20Tomko?= <address@hidden>
Date: Fri, 29 Jul 2016 22:39:31 -0700
Subject: [PATCH] maint.mk: speed up sc_po_check
sc_po_check would skip files based on their names, or on the
existence of files with derived names. Rewrite it to use perl
instead of shell to make the check faster.
* top/maint.mk (perl_translatable_files_list_): Define.
(sc_po_check): Use it.
---
ChangeLog | 9 +++++++++
top/maint.mk | 32 +++++++++++++++++---------------
2 files changed, 26 insertions(+), 15 deletions(-)
Looks good to me.
Jan
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH 1/4] maint.mk: speed up po_check,
Ján Tomko <=