[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/4] maint.mk: speed up po_check
From: |
Jim Meyering |
Subject: |
Re: [PATCH 1/4] maint.mk: speed up po_check |
Date: |
Fri, 29 Jul 2016 22:52:00 -0700 |
On Tue, Jul 26, 2016 at 7:28 AM, Ján Tomko <address@hidden> wrote:
> +2016-07-26 Ján Tomko <address@hidden>
> +
> + maint.mk: speed up po_check
> +
> + There is some logic in sc_po_check that skips files based on their
> + names, or existence of files with derived names.
> +
> + Rewrite it in perl instead of shell to make the check faster.
Thank you!
Nice change.
I've adjusted your patch and ChangeLog slightly:
- removed unnecessary $$ret=0
- I prefer to use (and the rest of the file uses) TABs for
right-margin "\" alignment
- I've adjusted the perl for style, and improved the
.[ly]-existence-checking section
With that, elapsed time for "make sc_po_check" in libvirt goes from
96s to just 16s.
I'll be happy to push the attached diff or something close, but will
wait a bit, in case there's something else to improve.
sc_po_check.diff
Description: Text document