Re: Wget compilation spammed with warnings and notes

[Tim Ruehsen]

Hi Paul,

first of all, thanks for your quick and comprehensive answer.

On Monday 13 June 2016 11:34:09 Paul Eggert wrote:
> On 06/13/2016 07:52 AM, Tim Ruehsen wrote:
> > Especially -Wlong-long and -pedantic floods the screen with warnings and
> > notes from gnulib modules. Finding any warnings emanated by Wget sources
> > becomes very tedious. Some example output below.
> > 
> > What do you suggest to avoid the verbose output from gnulib modules ?
> 
> These days to be frank C89 is lower priority. Gnulib still supports C89
> but I think most downstream projects have switched to C99 or later. The
> issue you mention is merely about compile-time-diagnostics, not about
> correctness, which makes it lower-priority still. That being said....
> 
> > ../lib/xalloc-oversized.h:41:5: warning: ISO C forbids braced-groups
> > within
> > expressions [-Wpedantic]
> > 
> >       ({ size_t __xalloc_size; __builtin_mul_overflow (n, s,
> >       &__xalloc_size);
> > 
> > })
> 
> I fixed that by installing the attached patch. I'd been meaning to do
> something in that area anyway, to accommodate the forthcoming GCC 7, so
> I did both at the same time.

Just updated gnulib here, your patch is in there, looks good with gcc 6 !

> > ../lib/intprops.h:85:28: warning: ISO C90 does not support 'long long' [-
> > Wlong-long]
> > 
> >   verify (TYPE_MAXIMUM (long long int) == LLONG_MAX);
> 
> I wouldn't worry about these. Any C89 compiler that defines LLONG_MAX
> without implementing 'long long' is (in a practical sense) busted
> anyway. I suggest adding -Wno-long-long to your compile-time options.
> You could tack it onto the end of the existing options, e.g.:

That's what I did. Thanks for your statement regarding LLONG_MAX.

> Or perhaps wget should start using Gnulib's manywarnings module, which
> does a better job of this sort of thing anyway.

Thanks for pointing me to manywarnings. I'll use in the future.


Just some minor warnings, if you like to fix them:

fatal-signal.c: In function 'install_handlers':
fatal-signal.c:196:19: warning: comparison between signed and unsigned integer 
expressions [-Wsign-compare]
         if (!(sig < sizeof (saved_sigactions) / sizeof 
(saved_sigactions[0])))
                   ^

fatal-signal.c: In function 'at_fatal_signal':
fatal-signal.c:216:21: warning: comparison between signed and unsigned integer 
expressions [-Wsign-compare]
   if (actions_count == actions_allocated)
                     ^~

wait-process.c: In function 'register_slave_subprocess':
wait-process.c:138:20: warning: comparison between signed and unsigned integer 
expressions [-Wsign-compare]
   if (slaves_count == slaves_allocated)
                    ^~

vasnprintf.c: In function 'vasnprintf':
vasnprintf.c:5107:35: warning: comparison between signed and unsigned integer 
expressions [-Wsign-compare]
                         if (count < maxlen
                                   ^

Best Reagrds, Tim

signature.asc
Description: This is a digitally signed message part.