[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Chop final '/' in output directory (RHBZ#1146753)
From: |
Pádraig Brady |
Subject: |
Re: [PATCH] Chop final '/' in output directory (RHBZ#1146753) |
Date: |
Thu, 15 Oct 2015 15:26:55 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 15/10/15 14:39, Pino Toscano wrote:
> If the specified output directory ends with a slash, chop it then;
> leaving it in will create problems later, like creating the temporary
> directory inside the output directory (and not aside it), and trying to
> rename it to the directory containing it (which will fail indeed).
> ---
> src/supermin.ml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/src/supermin.ml b/src/supermin.ml
> index 9623229..3070b6b 100644
> --- a/src/supermin.ml
> +++ b/src/supermin.ml
> @@ -186,6 +186,11 @@ let main () =
> eprintf "supermin: output directory (-o option) must be supplied\n";
> exit 1
> );
> + (* Chop final '/' in output directory (RHBZ#1146753). *)
> + let outputdir =
> + let len = String.length outputdir in
> + if outputdir.[len - 1] == '/' then String.sub outputdir 0 (len - 1)
> + else outputdir in
>
> debug, mode, if_newer, inputs, lockfile, outputdir,
> (copy_kernel, dtb_wildcard, format, host_cpu,
>
Wrong list. Ignoring...