[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [gnulib PATCH]: new warning from ar on rawhide systems

From: Pavel Raiskup
Subject: Re: [gnulib PATCH]: new warning from ar on rawhide systems
Date: Fri, 25 Sep 2015 17:34:20 +0200
User-agent: KMail/4.14.10 (Linux/4.2.1-300.fc23.x86_64+debug; KDE/4.14.11; x86_64; ; )

Berny, thanks for the review and sorry for the delay.

On Thursday 16 of July 2015 16:53:42 Bernhard Voelker wrote:
> On 07/16/2015 04:19 PM, Jim Meyering wrote:
> >    echo "$final_modules" | LC_ALL=C grep '^extensions$' >/dev/null \
> why would we need LC_ALL here at all?  IMO this is sufficient:
>      echo "$final_modules" | grep '^extensions$' >/dev/null \

I believed the LC_ALL=C should be faster..  But yes ..

> btw: one could even completely avoid the "| grep" by letting
> the shell do the matching:
>    nl='
>    '
>    case "${nl}${final_modules}${nl}" in
>      *"${nl}extensions${nl}"*) ...
>    esac

.. this seems to work and without pipes.

Adjusted patch re-attached.


Attachment: 0001-gnulib-common.m4-fix-gl_PROG_AR_RANLIB-AM_PROG_AR-cl.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]