[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: locale test failures on illumos
From: |
Pádraig Brady |
Subject: |
Re: locale test failures on illumos |
Date: |
Tue, 07 Jul 2015 11:22:10 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 07/07/15 07:46, Daiki Ueno wrote:
> Alexander Pyhalov <address@hidden> writes:
>
>> On 01/29/2015 19:53, Pádraig Brady wrote:
>>> On 19/01/15 14:01, Pádraig Brady wrote:
>>>> On 15/01/15 18:05, Alexander Pyhalov wrote:
>>
>>>> Does querylocale() exist for __sun ?
>>>> Perhaps it's just a matter of adding __sun to the elif define
>>>> in gl_locale_name_thread_unsafe() ?
>>>
>>> It seems this is hitting recently as solaris 12 added uselocale()
>>> which triggers this path. Rich Burridge tells me that the function
>>> used on solaris 12 is in fact getlocalename_l(), which
>>> may work for Illumos also?
>>
>> Hi, sorry for long silence (was on vacation for some time).
>> Illumos currently doesn't provid getlocalename_l() function (and as I
>> know any similar function).
>
> That is unfortunate. In that case, shouldn't we avoid referring to the
> missing symbol? This wouldn't fix the test failure, but IMO it would be
> better not to break builds:
> https://lists.gnu.org/archive/html/bug-libunistring/2015-07/msg00007.html
>
> Patch attached (not tested at all).
Yes it would be better to build and fail the test.
thanks,
Pádraig