[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 02/14] Fix character encoding aliases for OS/2
From: |
KO Myung-Hun |
Subject: |
Re: [PATCH 02/14] Fix character encoding aliases for OS/2 |
Date: |
Sat, 27 Dec 2014 00:49:46 +0900 |
User-agent: |
Mozilla/5.0 (OS/2; Warp 4.5; rv:10.0.6esrpre) Gecko/20120715 Firefox/10.0.6esrpre SeaMonkey/2.7.2 |
Daiki Ueno wrote:
> KO Myung-Hun <address@hidden> writes:
>
>> Thanks. ^^ And fixed typo, cp1361 to cp1381.
>
> Oops, thanks for fixing.
>
>>> By the way, it's tempting to call DosQueryCp if a charset is omitted
>>> from the locale name, to avoid maintaining the default mapping
>>> ourselves. I'd rather not do that for now, but is it feasible?
>>
>> This was my first idea. But Bruno rejected. See
>>
>> http://lists.gnu.org/archive/html/bug-gnu-libiconv/2011-03/msg00000.html
>
> Thanks for the link. If I understand correctly, the main point seems
> that the patch affects the codeset of the POSIX locale ("C" or "POSIX").
>
> For other locale values, POSIX says:
>
> If the locale value has the form:
>
> language[_territory][.codeset]
>
> it refers to an implementation-provided locale, where settings of
> language, territory, and codeset are implementation-defined.
>
> So, I don't see any problem using system's codepage as a default codeset
> of a language_territory locale (though it might conflict with the
> libiconv design). FWIW, kLIBC's nl_langinfo/setlocale implementation
> does this:
>
> - if codeset is specified as part of the locale name, use it
> - if the locale name is "C" or "POSIX", use "US-ASCII"
> - otherwise, fallback to DosQueryCp
>
> I'm attaching two patches: the first one is an update of the patch we
> are currently working on (I added mappings from the "unusable" codepages
> to their equivalents), and the second one is an alternative
> implementation following the kLIBC implementation.
I prefer second one. It was my first idea and more simple. ^^
Thanks a lot for your works.
--
KO Myung-Hun
Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM
Korean OS/2 User Community : http://www.ecomstation.co.kr
- Re: [PATCH 02/14] Fix character encoding aliases for OS/2, (continued)
- Re: [PATCH 02/14] Fix character encoding aliases for OS/2, Daiki Ueno, 2014/12/18
- Re: [PATCH 02/14] Fix character encoding aliases for OS/2, KO Myung-Hun, 2014/12/18
- Re: [PATCH 02/14] Fix character encoding aliases for OS/2, KO Myung-Hun, 2014/12/19
- Re: [PATCH 02/14] Fix character encoding aliases for OS/2, Daiki Ueno, 2014/12/19
- Re: [PATCH 02/14] Fix character encoding aliases for OS/2, KO Myung-Hun, 2014/12/19
- Re: [PATCH 02/14] Fix character encoding aliases for OS/2, Daiki Ueno, 2014/12/24
- Re: [PATCH 02/14] Fix character encoding aliases for OS/2, KO Myung-Hun, 2014/12/24
- Re: [PATCH 02/14] Fix character encoding aliases for OS/2, Daiki Ueno, 2014/12/25
- Re: [PATCH 02/14] Fix character encoding aliases for OS/2, KO Myung-Hun, 2014/12/25
- Re: [PATCH 02/14] Fix character encoding aliases for OS/2, Daiki Ueno, 2014/12/26
- Re: [PATCH 02/14] Fix character encoding aliases for OS/2,
KO Myung-Hun <=
[PATCH 03/14] relocatable: support UNIXROOT in relocate() on EMX, KO Myung-Hun, 2014/12/08
[PATCH 04/14] binary-io: don't put fd in binary mode if it is a console on EMX, KO Myung-Hun, 2014/12/08
[PATCH 05/14] pipe-filter-aux: undefine HAVE_SELECT on KLIBC, KO Myung-Hun, 2014/12/08
[PATCH 06/14] w32spawn: clear SHELL_SPECIAL_CHARS and SHELL_SPACE_CHAR on OS/2 kLIBC, KO Myung-Hun, 2014/12/08
[PATCH 07/14] getdtablesize: do not use getrlimit() on OS/2 kLIBC, KO Myung-Hun, 2014/12/08
[PATCH 08/14] wcwidth: fix 'conflicting types' error for `__wcwidth' on OS/2 kLIBC, KO Myung-Hun, 2014/12/08