Re: [PATCH] stringops: add new module

[Paul Eggert]

Kieran Colford wrote:
> +/* Test if the strings X and Y are equal. */
> +#define STREQ(X, Y) (strcmp (X, Y) == 0)
> +
> +/* Test if the strings a and b are equal. */
> +static inline bool
> +streq (const char *a, const char *b)

I think the latest idea was to have just one name, STREQ, and to have it 
be an inline function and not a macro.

STREQ shouldn't be static inline; lib/stringops.h should use the 
_GL_INLINE_HEADER_BEGIN family of macros, like (for example) lib/xtime.h 
does.