bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 2/2] Removed sc_prohibit_strcmp from the syntax-check


From: Kieran Colford
Subject: [PATCH 2/2] Removed sc_prohibit_strcmp from the syntax-check
Date: Wed, 21 May 2014 14:00:13 -0400

With the removal of STREQ and STRNEQ from gnulib, this syntax test is
no longer useful and simply generates a nuisance error message that
can't be fixed by gnulib.
---
 top/maint.mk |    8 --------
 1 file changed, 8 deletions(-)

diff --git a/top/maint.mk b/top/maint.mk
index b6cd5a2..5b345ad 100644
--- a/top/maint.mk
+++ b/top/maint.mk
@@ -357,14 +357,6 @@ sc_prohibit_atoi_atof:
        halt='do not use *scan''f, ato''f, ato''i, ato''l, ato''ll or ato''q'   
\
          $(_sc_search_regexp)
 
-# Use STREQ rather than comparing strcmp == 0, or != 0.
-sp_ = strcmp *\(.+\)
-sc_prohibit_strcmp:
-       @prohibit='! *strcmp *\(|\<$(sp_) *[!=]=|[!=]= *$(sp_)'         \
-       exclude='# *define STRN?EQ\('                                   \
-       halt='replace strcmp calls above with STREQ/STRNEQ'             \
-         $(_sc_search_regexp)
-
 # Really.  You don't want to use this function.
 # It may fail to NUL-terminate the destination,
 # and always NUL-pads out to the specified length.
-- 
1.7.9.5




reply via email to

[Prev in Thread] Current Thread [Next in Thread]