[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] warnings: extend -Wno-foo handling to work through shell var
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH] warnings: extend -Wno-foo handling to work through shell vars |
|
Date: |
Thu, 15 Aug 2013 13:44:14 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 |
On 08/15/2013 01:39 PM, Paul Eggert wrote:
> Eric Blake wrote:
>> + -Wno-*) gl_positive=`echo ".$gl_positive" | sed 's/^.//; s/^-Wno-/-W/'`;;
>
> This should use expr, e.g.,
>
> gl_positive=-W`expr "X$gl_positive" : 'X-Wno-\(.)\)'`
Indeed a slightly more efficient expression. Pushed as a followup.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature