Re: bug#14253: Testsuite failure in gnulib-tests: test programs cannot be built

[Paul Eggert]

On 04/24/2013 02:08 AM, Pádraig Brady wrote:
> Bernhard noticed this also:
> http://lists.gnu.org/archive/html/coreutils/2013-03/msg00065.html

Thanks, here's a proposed patch.  I'll CC: this to Bruno since he's
gettext's maintainer.

>From 319571c0a0ad96d60f00470ef5d0ac8cc83c194b Mon Sep 17 00:00:00 2001
From: Paul Eggert <address@hidden>
Date: Wed, 24 Apr 2013 22:26:31 -0700
Subject: [PATCH] gettext: now your responsibility to add
 -$(top_builddir)/intl

Formerly, it was your responsibility to do this for all Makefile.ams
other than Gnulib's.  Now it's your responsibility to do it for
Gnulib's Makefile.am, too.
* NEWS: Document this.
* modules/gettext (AM_CPPFLAGS): Don't append -$(top_builddir)/intl.
---
 ChangeLog       |  9 +++++++++
 NEWS            |  4 ++++
 modules/gettext | 17 +++++++++--------
 3 files changed, 22 insertions(+), 8 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index f49e881..805f5fb 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2013-04-24  Paul Eggert  <address@hidden>
+
+       gettext: now your responsibility to add -$(top_builddir)/intl
+       Formerly, it was your responsibility to do this for all Makefile.ams
+       other than Gnulib's.  Now it's your responsibility to do it for
+       Gnulib's Makefile.am, too.
+       * NEWS: Document this.
+       * modules/gettext (AM_CPPFLAGS): Don't append -$(top_builddir)/intl.
+
 2013-04-11  Dmitry V. Levin  <address@hidden>
 
        regex-tests, regex: allow glibc re_search behavior
diff --git a/NEWS b/NEWS
index 2227d3f..fa3a8c6 100644
--- a/NEWS
+++ b/NEWS
@@ -3,6 +3,10 @@ Important notes
 
 Date        Modules         Changes
 
+2013-04-24  gettext         If your project uses 'gettextize --intl' it is now
+                            your responsibility to put -I$(top_builddir)/intl
+                            into the Makefile.am for gnulib.
+
 2012-06-27  elisp-comp      The module 'elisp-comp' is removed; the script is
                             not independently useful outside of automake.
 
diff --git a/modules/gettext b/modules/gettext
index ca0b684..3da0e2e 100644
--- a/modules/gettext
+++ b/modules/gettext
@@ -45,15 +45,16 @@ AM_GNU_GETTEXT([external])
 AM_GNU_GETTEXT_VERSION([0.18.1])
 
 Makefile.am:
-# This is for those projects which use "gettextize --intl" to put a source-code
-# copy of libintl into their package. In such projects, every Makefile.am needs
+# If your project uses "gettextize --intl" to put a source-code
+# copy of libintl into the package, every Makefile.am needs
 # -I$(top_builddir)/intl, so that <libintl.h> can be found in this directory.
-# For the Makefile.ams in other directories it is the maintainer's
-# responsibility; for the one from gnulib we do it here.
-# This option has no effect when the user disables NLS (because then the intl
-# directory contains no libintl.h file) or when the project does not use
-# "gettextize --intl".
-AM_CPPFLAGS += -I$(top_builddir)/intl
+# Here's one way to do this:
+#AM_CPPFLAGS += -I$(top_builddir)/intl
+# This option has no effect when the user disables NLS (because then
+# the intl directory contains no libintl.h file).  This option is not
+# enabled by default because the intl directory might not exist if
+# your project does not use "gettext --intl", and some compilers
+# complain about -I options applied to nonexistent directories.
 
 Include:
 "gettext.h"
-- 
1.7.11.7