[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Bug: tests/fsync.c: don't check for fsync failure on invalid fd
From: |
Phillip Susi |
Subject: |
Re: Bug: tests/fsync.c: don't check for fsync failure on invalid fd |
Date: |
Wed, 13 Mar 2013 09:55:01 -0400 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130307 Thunderbird/17.0.4 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Please use your mail agent's reply-to-all function on public mailing
lists. I did not see this until now because I am not subscribed, and
then I had to download and import the archive to reply properly.
On 2/15/2013 3:59 PM, Eric Blake wrote:
> On 02/15/2013 12:40 PM, Phillip Susi wrote:
>> tests/test-fsync.c asserts that fsync() fails with -EBADF when
>> given an invalid fd. This fails when using the libeatmydata
>> LD_PRELOAD library to turn all fsyncs into silent noops.
>
> That's a bug in the libeatmydata library; I'm not sure it is worth
> working around in gnulib.
How is it a bug in libeatmydata? There is no action, so there is
nothing to fail. Why does gnulib care that it fails when used
wrongly? That's a bit like dereferencing an invalid pointer and
complaining that you didn't get a SEGV.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (MingW32)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQEcBAEBAgAGBQJRQIU1AAoJEJrBOlT6nu75KrYH/iCf9aKGRniwkqJ6BEWdaYQ9
A1QjOrn4lQ5XkL1h6K3Jbz7QLq4Yh8hfb+I8GVTqmnImAxZLu+a1gITFNmsqD6kq
edcRlzqJr1RhqW1wokFdUkDbMRAd2a3uCtT8c08tI4eEFLALE/DeaevvSz/yYDPl
GmgQcf/ZY1YH17mHdI7UmINQUqmxpoS3Rlj/ZZtMWRvkK+HLvY6t9IEdKPof0juw
P0vvb6IXeFXw50F77bCi7yVjMyMtK3Ofj43vtm7t+4ePh0IBgkq/bhV1YhePrzz6
Ko6cNPlJnh85Yq4IXuoKnkIPJFC1/5ysMmC/9pNF/zheBVUhzQhk4NSgIzNwvfs=
=Bk4x
-----END PGP SIGNATURE-----
- Re: Bug: tests/fsync.c: don't check for fsync failure on invalid fd,
Phillip Susi <=
- Re: Bug: tests/fsync.c: don't check for fsync failure on invalid fd, Eric Blake, 2013/03/13
- Re: Bug: tests/fsync.c: don't check for fsync failure on invalid fd, Phillip Susi, 2013/03/13
- Re: Bug: tests/fsync.c: don't check for fsync failure on invalid fd, Paul Eggert, 2013/03/13
- Re: Bug: tests/fsync.c: don't check for fsync failure on invalid fd, Phillip Susi, 2013/03/13
- Re: Bug: tests/fsync.c: don't check for fsync failure on invalid fd, Eric Blake, 2013/03/13
- Re: Bug: tests/fsync.c: don't check for fsync failure on invalid fd, Phillip Susi, 2013/03/13
- Re: Bug: tests/fsync.c: don't check for fsync failure on invalid fd, Paul Eggert, 2013/03/13
- Re: Bug: tests/fsync.c: don't check for fsync failure on invalid fd, Phillip Susi, 2013/03/13
- Re: Bug: tests/fsync.c: don't check for fsync failure on invalid fd, Eric Blake, 2013/03/13
- Re: Bug: tests/fsync.c: don't check for fsync failure on invalid fd, Phillip Susi, 2013/03/13