[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: bug#11905: Unnecessary '#define unix' in src/s/aix4-2.h
From: |
Jim Meyering |
Subject: |
Re: bug#11905: Unnecessary '#define unix' in src/s/aix4-2.h |
Date: |
Wed, 11 Jul 2012 09:26:05 +0200 |
Paul Eggert wrote:
> On 07/10/2012 04:25 PM, Glenn Morris wrote:
>> I suspect that Gnulib already has the AIX
>> case covered (via "__unix"?), so that src/s/aix4-2.h no longer needs to
>> define "unix".
>
> Yes, that sounds right. I have started to fix this by
> installing the following patch into gnulib, and will
> propagate this into Emacs shortly.
>
> ---
> ChangeLog | 9 +++++++++
> lib/getloadavg.c | 28 +++-------------------------
> m4/getloadavg.m4 | 2 ++
> 3 files changed, 14 insertions(+), 25 deletions(-)
>
> diff --git a/ChangeLog b/ChangeLog
> index d94f7b1..b27ef8d 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,12 @@
> +2012-07-10 Paul Eggert <address@hidden>
> +
> + getloadavg: clean out old Emacs and Autoconf cruft
> + See Glenn Morris in <http://bugs.gnu.org/11905>.
> + * lib/getloadavg.c: Include <config.h>, <stdbool.h> always.
> + Include <sys/param.h> if HAVE_SYS_PARAM_H, not if unix or __unix.
> + (LDAV_CVT): Remove no-longer-used LOAD_AVE_CVT hook.
> + * m4/getloadavg.m4 (gl_PREREQ_GETLOADAVG): Check for <sys/param.h>.
Welcome clean-up. Thanks!