[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] canonicalize: make the right guess when cross-compiling
From: |
Bruno Haible |
Subject: |
Re: [PATCH 1/2] canonicalize: make the right guess when cross-compiling to GNU |
Date: |
Sun, 08 Jul 2012 18:32:57 +0200 |
User-agent: |
KMail/4.7.4 (Linux/3.1.10-1.9-desktop; KDE/4.7.4; x86_64; ; ) |
Hi Ludo,
> [case "$host_os" in
> # Guess yes on glibc systems.
> - *-gnu*) gl_cv_func_realpath_works="guessing yes" ;;
> + *gnu*) gl_cv_func_realpath_works="guessing yes" ;;
> # If we don't know, assume the worst.
> *) gl_cv_func_realpath_works="guessing no" ;;
The Hurd porting guidelines [1] recommend to use an | gnu*
clause. This also sounds more future-proof: imagine what if a new OS
comes along with the name 'bignux' or similar. The clause *gnu* would
match it.
[1] http://www.gnu.org/software/hurd/hurd/porting/guidelines.html
2012-07-07 Ludovic Courtès <address@hidden>
Bruno Haible <address@hidden>
canonicalize: make the right guess when cross-compiling to GNU
* m4/canonicalize.m4 (gl_FUNC_REALPATH_WORKS): Match also "gnu*" to
determine whether cross-compiling to glibc systems, so as to
include GNU/Hurd.
diff --git a/m4/canonicalize.m4 b/m4/canonicalize.m4
index 69b3f4c..5acf6f0 100644
--- a/m4/canonicalize.m4
+++ b/m4/canonicalize.m4
@@ -1,4 +1,4 @@
-# canonicalize.m4 serial 24
+# canonicalize.m4 serial 25
dnl Copyright (C) 2003-2007, 2009-2012 Free Software Foundation, Inc.
@@ -94,10 +94,10 @@ AC_DEFUN([gl_FUNC_REALPATH_WORKS],
[gl_cv_func_realpath_works=yes],
[gl_cv_func_realpath_works=no],
[case "$host_os" in
- # Guess yes on glibc systems.
- *-gnu*) gl_cv_func_realpath_works="guessing yes" ;;
- # If we don't know, assume the worst.
- *) gl_cv_func_realpath_works="guessing no" ;;
+ # Guess yes on glibc systems.
+ *-gnu* | gnu*) gl_cv_func_realpath_works="guessing yes" ;;
+ # If we don't know, assume the worst.
+ *) gl_cv_func_realpath_works="guessing no" ;;
esac
])
rm -rf conftest.a conftest.d