[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/8] maint: remove empty lines at EOF, but excluding modules/
From: |
Jim Meyering |
Subject: |
Re: [PATCH 2/8] maint: remove empty lines at EOF, but excluding modules/* |
Date: |
Wed, 18 Jan 2012 09:32:39 +0100 |
Karl Berry wrote:
> However, I am optimistic that I will be able to make matching
> changes upstream.
>
> Sorry, but for myself, I think it is a terrible waste of time to be
> thinking about this for fdl*.texi. The blank lines don't hurt anything
Hi Karl,
I know this hurts your sensibilities, but try to see it from
the other perspective... consistency matters, and fixing difficult-
to-access sources is surely less expensive in the long run than
exempting these shared files from multiple checks in multiple projects.
Isn't it a waste of time/effort to have to remember that Karl says
certain files cannot be subject to such changes?
Otherwise they must be exempted (manually, requiring more time)
from these automated consistency checks in any project, like
autoconf, that version-controls these files.
Seems better to fix it once, at the root, than to work around
it repeatedly.
> and you're not supposed to be modifying those files, so can't we just
> leave them alone? Argh.
>
> As for these files:
>
> >> * doc/Copyright/assign.translation.manual: Remove empty lines at EOF.
> >> * doc/Copyright/request-assign.future: Likewise.
> >> * doc/Copyright/request-disclaim.changes: Likewise.
>
> The originals of those files live on some inaccessible FSF machine
> somewhere, as far as I know. You're not really going to take up
> Donald's time with such a thing, are you?
You mean take up a minute or two of his time to have
him run a perl one-liner on those files? Once removed
they tend to stay gone, unless someone appends text to the
very end of the file.
If those files are so inaccessible, I guess they don't change often,
so my gnulib-local changes may last a long time.
Now I'm sure to be removed from your Christmas list ;-)
Jim
- [PATCH 5/8] maint: enable sc_prohibit_intprops_without_use, (continued)
- [PATCH 5/8] maint: enable sc_prohibit_intprops_without_use, Jim Meyering, 2012/01/17
- [PATCH 8/8] maint: enable sc_trailing_blank, Jim Meyering, 2012/01/17
- [PATCH 7/8] maint: enable sc_prohibit_openat_without_use, Jim Meyering, 2012/01/17
- [PATCH 1/8] maint: add framework to run syntax-check rules against gnulib sources, Jim Meyering, 2012/01/17
- [PATCH 3/8] maint: enable double-word-prohibiting rule, Jim Meyering, 2012/01/17
- [PATCH 2/8] maint: remove empty lines at EOF, but excluding modules/*, Jim Meyering, 2012/01/17
- Re: [PATCH 2/8] maint: remove empty lines at EOF, but excluding modules/*, Bruno Haible, 2012/01/17
- Re: [PATCH 2/8] maint: remove empty lines at EOF, but excluding modules/*, Jim Meyering, 2012/01/17
- Re: [PATCH 2/8] maint: remove empty lines at EOF, but excluding modules/*, Bruno Haible, 2012/01/17
- Re: [PATCH 2/8] maint: remove empty lines at EOF, but excluding modules/*, Karl Berry, 2012/01/17
- Re: [PATCH 2/8] maint: remove empty lines at EOF, but excluding modules/*,
Jim Meyering <=
- Re: [PATCH 2/8] maint: remove empty lines at EOF, but excluding modules/*, Paul Eggert, 2012/01/17
- Re: [PATCH 2/8] maint: remove empty lines at EOF, but excluding modules/*, Bruno Haible, 2012/01/17
- Re: [PATCH 2/8] maint: remove empty lines at EOF, but excluding modules/*, Jim Meyering, 2012/01/18
- Re: [PATCH 2/8] maint: remove empty lines at EOF, but excluding modules/*, Eric Blake, 2012/01/21
- Re: [PATCH 2/8] maint: remove empty lines at EOF, but excluding modules/*, Jim Meyering, 2012/01/21
- Re: [PATCH 2/8] maint: remove empty lines at EOF, but excluding modules/*, Jim Meyering, 2012/01/21
- Re: [PATCH 2/8] maint: remove empty lines at EOF, but excluding modules/*, Bruno Haible, 2012/01/21
- Re: [PATCH 2/8] maint: remove empty lines at EOF, but excluding modules/*, Jim Meyering, 2012/01/21
- Re: [PATCH 2/8] maint: remove empty lines at EOF, but excluding modules/*, Eric Blake, 2012/01/23
- Re: [PATCH 2/8] maint: remove empty lines at EOF, but excluding modules/*, Paul Eggert, 2012/01/23