bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tests: factor st_ctime-comparison out of two headers


From: Bruno Haible
Subject: Re: [PATCH] tests: factor st_ctime-comparison out of two headers
Date: Sat, 19 Nov 2011 17:35:48 +0100
User-agent: KMail/1.13.6 (Linux/2.6.37.6-0.5-desktop; KDE/4.6.0; x86_64; ; )

Hi Jim,

> If we drop the "inline", then any compilation unit that includes
> that header without using the function will get a warning about
> the unused static function.

Ah right, you have more gcc warnings enabled typically than I do.

Can you give me the list of warnings options that you use on glibc systems,
so that I can change my build scripts to show the same warnings that you
would see? I remember that you use -Wshadow; what else?

> However, I will add the four AC_REQUIRE lines.

I did that now.


2011-11-19  Bruno Haible  <address@hidden>

        Ensure 'inline' can be used in tests/test-utimens-common.h.
        * modules/fdutimensat-tests (configure.ac): Require AC_C_INLINE.
        * modules/futimens-tests (configure.ac): Likewise.
        * modules/utimens-tests (configure.ac): Likewise.
        * modules/utimensat-tests (configure.ac): Likewise.

diff --git a/modules/fdutimensat-tests b/modules/fdutimensat-tests
index 1ca9b0a..7099e68 100644
--- a/modules/fdutimensat-tests
+++ b/modules/fdutimensat-tests
@@ -16,6 +16,7 @@ usleep
 utimecmp
 
 configure.ac:
+AC_REQUIRE([AC_C_INLINE])
 
 Makefile.am:
 TESTS += test-fdutimensat
diff --git a/modules/futimens-tests b/modules/futimens-tests
index bfd65f6..3076920 100644
--- a/modules/futimens-tests
+++ b/modules/futimens-tests
@@ -14,6 +14,7 @@ usleep
 utimecmp
 
 configure.ac:
+AC_REQUIRE([AC_C_INLINE])
 
 Makefile.am:
 TESTS += test-futimens
diff --git a/modules/utimens-tests b/modules/utimens-tests
index 4d5d1f5..802d8e5 100644
--- a/modules/utimens-tests
+++ b/modules/utimens-tests
@@ -16,6 +16,7 @@ usleep
 utimecmp
 
 configure.ac:
+AC_REQUIRE([AC_C_INLINE])
 
 Makefile.am:
 TESTS += test-utimens
diff --git a/modules/utimensat-tests b/modules/utimensat-tests
index 6acfe89..ec426bb 100644
--- a/modules/utimensat-tests
+++ b/modules/utimensat-tests
@@ -14,6 +14,7 @@ usleep
 utimecmp
 
 configure.ac:
+AC_REQUIRE([AC_C_INLINE])
 
 Makefile.am:
 TESTS += test-utimensat

-- 
In memoriam Farhád Asdaqí 
<http://www.iranhrdc.org/english/publications/reports/3149-a-faith-denied-the-persecution-of-the-baha-is-of-iran.html?p=29>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]