bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: gl_ABSOLUTE_HEADER_ONE and older seds


From: Paul Eggert
Subject: Re: gl_ABSOLUTE_HEADER_ONE and older seds
Date: Thu, 13 Oct 2011 16:18:17 -0700
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.23) Gecko/20110928 Fedora/3.1.15-1.fc14 Thunderbird/3.1.15

On 10/13/11 15:36, Daniel Richard G. wrote:
> It's a fairly small and straightforward patch

Hmm, but isn't it a bit iffy?
With the patch, a string with '\' is passed to 'echo',
and that's not portable.  Maybe it works on mingw, maybe
not (I don't use mingw).

How about the following patch instead?  It's the same number
of bytes as the original, so arguably it addresses the
complexity issue.  To be honest, though, I don't want to
be dragged down the slippery slope of supporting museum
pieces, as that's not Gnulib's job.

diff --git a/m4/absolute-header.m4 b/m4/absolute-header.m4
index b7276a3..031bc21 100644
--- a/m4/absolute-header.m4
+++ b/m4/absolute-header.m4
@@ -81,12 +81,12 @@ changequote(,)
       gl_dirsep_regex='/'
       ;;
   esac
-  gl_absolute_header_sed='\|'"${gl_dirsep_regex}"'$1|{
+  gl_absolute_header_sed='\|'"${gl_dirsep_regex}"'$1|!d
       s|.*"\(.*'"${gl_dirsep_regex}"'$1\)".*|\1|
       s|^/[^/]|//&|
       p
       q
-    }'
+    '
 changequote([,])
   dnl eval is necessary to expand gl_absname_cpp.
   dnl Ultrix and Pyramid sh refuse to redirect output of eval,



reply via email to

[Prev in Thread] Current Thread [Next in Thread]