Re: relocatable-prog needs AC_LIBOBJ([relocatable])?

[Ben Pfaff]

Bruno Haible <address@hidden> writes:

>> Before commit 357d319ff8 "relocatable-lib: Move AC_LIBOBJ
>> invocations to module description", this worked fine.  But that
>> commit removed the call to AC_LIBOBJ([relocatable]) from
>> m4/relocatable.m4 in gl_RELOCATABLE_LIBRARY (which
>> relocatable-prog calls), moving it instead into
>> modules/relocatable-lib.  Since PSPP doesn't use the
>> relocatable-lib module, it doesn't build lib/relocatable.c.  This
>> causes link errors for relocate() and other functions.
>> 
>> The following fixes the link errors.  Is it the correct fix?
>
> Yes, it is 100% correct. Thank you for the fix!

Thank you for verifying.  I pushed this fix as follows:

--8<--------------------------cut here-------------------------->8--

From: Ben Pfaff <address@hidden>
Date: Mon, 15 Aug 2011 22:33:25 -0700
Subject: [PATCH] relocatable-prog: fix link error

* modules/relocatable-prog (configure.ac) [RELOCATABLE]: Also
invoke AC_LIBOBJ([relocatable]).  This invocation was previously
in the gl_RELOCATABLE_LIBRARY macro.  That invocation was moved
into modules/relocatable-lib without noticing that
modules/relocatable-prog also invokes gl_RELOCATABLE_LIBRARY and
also needs to build relocatable.c.
---
 ChangeLog                |   10 ++++++++++
 modules/relocatable-prog |    1 +
 2 files changed, 11 insertions(+), 0 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 6535a0d..aab48d7 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,13 @@
+2011-08-15  Ben Pfaff  <address@hidden>
+
+       relocatable-prog: fix link error
+       * modules/relocatable-prog (configure.ac) [RELOCATABLE]: Also
+       invoke AC_LIBOBJ([relocatable]).  This invocation was previously
+       in the gl_RELOCATABLE_LIBRARY macro.  That invocation was moved
+       into modules/relocatable-lib without noticing that
+       modules/relocatable-prog also invokes gl_RELOCATABLE_LIBRARY and
+       also needs to build relocatable.c.
+
 2011-08-12  Paul Eggert  <address@hidden>
 
        getaddrinfo: fix sh typo in gai_strerrorA decl checking
diff --git a/modules/relocatable-prog b/modules/relocatable-prog
index a7f50ac..72bc253 100644
--- a/modules/relocatable-prog
+++ b/modules/relocatable-prog
@@ -28,6 +28,7 @@ configure.ac:
 gl_RELOCATABLE([$gl_source_base])
 if test $RELOCATABLE = yes; then
   AC_LIBOBJ([progreloc])
+  AC_LIBOBJ([relocatable])
 fi
 
 Makefile.am:
-- 
Ben Pfaff 
http://benpfaff.org