bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] mmap-anon.m4: do not use regex in AC_EGREP_CPP


From: Eric Blake
Subject: Re: [PATCH] mmap-anon.m4: do not use regex in AC_EGREP_CPP
Date: Tue, 28 Jun 2011 06:35:55 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.10

On 06/28/2011 05:14 AM, Paolo Bonzini wrote:
> grep restricts its use of grep to things that are effectively fixed
> strings, in order to remove a recursive dependency on a "good" grep that
> supports arbitrarily long lines.  However, mmap-anon.m4 has one such
> instance.  This patch, suggested by Rainer Orth, removes "special"
> characters from the string being sought.
> 
> Ok?
> 
> Paolo
> 
> 2011-06-27  Paolo Bonzini  <address@hidden>
> 
>     * m4/mmap-anon.m4: Do not use special characters in the
>     regular expression.

Makes sense to me.  Go for it!

-- 
Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]