Re: [PATCH] tests init: new subroutine 'fatal_', for hard errors

[Eric Blake]

On 06/07/2011 05:58 AM, Stefano Lattarini wrote:
> Before this patch, the only way offered by tests/init.sh to
> properly signal an hard error was the `framework_failure_'

> +++ b/tests/init.sh
> @@ -77,6 +77,7 @@ Exit () { set +e; (exit $1); exit $1; }
>  warn_ () { echo "$@" 1>&$stderr_fileno_; }
>  fail_ () { warn_ "$ME_: failed test: $@"; Exit 1; }
>  skip_ () { warn_ "$ME_: skipped test: $@"; Exit 77; }
> +fatal_ () { warn_ "$ME_: hard error: $@"; Exit 99; }
>  framework_failure_ () { warn_ "$ME_: set-up failure: $@"; Exit 99; }

Simple enough, and makes sense.  ACK.

I was about to suggest rewriting framework_failure_ in terms of fatal_,
but that won't work ("hard error" and "set-up failure" should remain
distinct messages).

-- 
Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature