[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCHv2] strerror: drop strerror_r dependency
From: |
Bruno Haible |
Subject: |
Re: [PATCHv2] strerror: drop strerror_r dependency |
Date: |
Mon, 6 Jun 2011 23:05:20 +0200 |
User-agent: |
KMail/1.9.9 |
Eric Blake wrote:
> ... Compare to the problem we
> were solving earlier with fclose vs. fflush being in separate
> directories, and the AC_LIBOBJ([fflush]) giving us grief.
>
> Which is why we need a separate module as prereq for both strerror and
> strerror_r-posix, so that the AC_LIBOBJ only occurs in one directory
> corresponding to where strerror-override.c is placed.
A separate module is generally a good thing in a situation like this, yes.
I didn't mean to dissuade you from creating the separate module.
> If you have
> strerror in libs and strerror_r in tests, and both try to do AC_LIBOBJ,
> then you get into the funky situation where strerror-overrided.c is not
> in the tests directory and the build fails.
It will work *if* both strerror and strerror_r-posix have
lib/strerror-overrided.c among their file list. The rule about AC_LIBOBJ is:
The module which triggers an AC_LIBOBJ([foo]) must have lib/foo.c in its
file list. Look in gnulib-tool, function func_modules_to_filelist_separately,
how the final file list will be computed.
It's done correctly in module 'malloc-posix' and 'malloc-gnu', for example.
But there are many places in gnulib which we need to fix.
Bruno
--
In memoriam Robert F. Kennedy <http://en.wikipedia.org/wiki/Robert_F._Kennedy>
- [PATCHv2] strerror: drop strerror_r dependency, Eric Blake, 2011/06/01
- Re: [PATCHv2] strerror: drop strerror_r dependency, Bruno Haible, 2011/06/03
- [PATCH 1/2] strerror-override: avoid bloating errno module, Eric Blake, 2011/06/06
- [PATCH 2/2] strerror: work around FreeBSD bug, Eric Blake, 2011/06/06
- Re: [PATCH 2/2] strerror: work around FreeBSD bug, Bruno Haible, 2011/06/07
- Re: [PATCH 2/2] strerror: work around FreeBSD bug, Eric Blake, 2011/06/07
- Re: [PATCH 2/2] strerror: work around FreeBSD bug, Eric Blake, 2011/06/07
- MacOS strerror_r [was: [PATCH 2/2] strerror: work around FreeBSD bug], Eric Blake, 2011/06/08
- Re: MacOS strerror_r, Eric Blake, 2011/06/08
- Re: [PATCH 2/2] strerror: work around FreeBSD bug, Eric Blake, 2011/06/08
Re: [PATCHv2] strerror: drop strerror_r dependency, Bruno Haible, 2011/06/04