[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCHv2 4/9] save-cwd: reduce dependency
From: |
Eric Blake |
Subject: |
Re: [PATCHv2 4/9] save-cwd: reduce dependency |
Date: |
Wed, 27 Apr 2011 12:54:37 -0600 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110307 Fedora/3.1.9-0.39.b3pre.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.9 |
On 04/27/2011 10:03 AM, Jim Meyering wrote:
> Eric Blake wrote:
>> On 04/27/2011 01:37 AM, Jim Meyering wrote:
>>> Eric Blake wrote:
>>>> save-cwd needs either a working fchdir or a working getcwd(NULL).
>>>> The only platform where getcwd fixes problems not solved by
>>>> getcwd-lgpl is Linux, but fchdir works there.
>>>>
> Reducing robustness solely to reduce dependencies...
> That could introduce a subtle flaw in a package that depends on the
> robustness -- if the package maintainer doesn't read gnulib's NEWS.
> Not so sure I like that, but I do recognized the value.
>
> I guess it's ok if it's well documented.
> Be sure to mention in NEWS that by default (without explicit
> inclusion of the getcwd module), the save-cwd module is no longer robust.
I updated NEWS and the save-cwd.c comments as recommended, as well as
reworded the commit message to be more verbose about the issue, then pushed.
--
Eric Blake address@hidden +1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[PATCHv2 2/9] getcwd-lgpl: new module, Eric Blake, 2011/04/26
[PATCHv2 5/9] dirent-safer: drop unused link dependency, Eric Blake, 2011/04/26
[PATCHv2 6/9] tests: reduce dependencies, Eric Blake, 2011/04/26
[PATCHv2 3/9] getcwd: enhance tests, Eric Blake, 2011/04/26