bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] maint.mk: prohibit use of "can not"


From: Jim Meyering
Subject: [PATCH] maint.mk: prohibit use of "can not"
Date: Sat, 09 Apr 2011 23:02:00 +0200

There was a new use of "can not" in coreutils despite
my having performed this transformation before.
Autoconf is the same: one current/new violation,
in spite of applying the fix before.
I noticed that James Youngman recently fixed one in findutils
and there are several here in gnulib.

With this, new offenses will be less likely.

>From 2ba828d7b521d831648a4d0926d7885705cf1d59 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Sat, 9 Apr 2011 22:58:06 +0200
Subject: [PATCH] maint.mk: prohibit use of "can not"

* top/maint.mk (sc_prohibit_can_not): New rule.
Writing "can not" (rather than "cannot") is too common.  Prohibit it.
---
 ChangeLog    |    6 ++++++
 top/maint.mk |    5 +++++
 2 files changed, 11 insertions(+), 0 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 8ea526d..003ebed 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2011-04-09  Jim Meyering  <address@hidden>
+
+       maint.mk: prohibit use of "can not"
+       * top/maint.mk (sc_prohibit_can_not): New rule.
+       Writing "can not" (rather than "cannot") is too common.  Prohibit it.
+
 2011-04-09  Bruno Haible  <address@hidden>

        careadlinkat: Guard against misuse of careadlinkatcwd.
diff --git a/top/maint.mk b/top/maint.mk
index 693e5ab..823e46c 100644
--- a/top/maint.mk
+++ b/top/maint.mk
@@ -841,6 +841,11 @@ sc_prohibit_S_IS_definition:
        halt='do not define S_IS* macros; include <sys/stat.h>'         \
          $(_sc_search_regexp)

+sc_prohibit_can_not:
+       @prohibit='\<can[ ]not\>'                                       \
+       halt='use "cannot", not "can'' not"'                            \
+         $(_sc_search_regexp)
+
 _ptm1 = use "test C1 && test C2", not "test C1 -''a C2"
 _ptm2 = use "test C1 || test C2", not "test C1 -''o C2"
 # Using test's -a and -o operators is not portable.
--
1.7.5.rc1.228.g86d60b



reply via email to

[Prev in Thread] Current Thread [Next in Thread]