[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Remove xalloc.h dependency from parse-duration
|
From: |
Eric Blake |
|
Subject: |
Re: Remove xalloc.h dependency from parse-duration |
|
Date: |
Thu, 03 Mar 2011 15:35:35 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.7 |
On 03/03/2011 03:16 PM, Bruce Korb wrote:
> xalloc.h drags in too much stuff:
>
> parse_period (cch_t * in_pz)
> {
> - char * pz = xstrdup (in_pz);
> - char * pT = strchr (pz, 'T');
> + char * pz = strdup (in_pz);
> + char * pT;
> char * ps;
> void * fptr = pz;
> time_t res = 0;
>
> - if (pT != NUL)
> + if (pz == NULL)
> + return BAD_TIME;
Here, you want errno to be ENOMEM, but mingw doesn't guarantee that...
> Depends-on:
> -xalloc
...so either add a dependency on strdup-posix here, or else modify the
code to manually set errno on that failure path.
ACK with that fixed.
--
Eric Blake address@hidden +1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature