bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: new branch in gnulib: coreutils-8.9


From: Jim Meyering
Subject: Re: new branch in gnulib: coreutils-8.9
Date: Tue, 04 Jan 2011 22:15:53 +0100

Jim Meyering wrote:
> In releasing coreutils-8.9, I left its gnulib submodule pointing at a
> private commit that was going to be pushed, pending an ACK...  Since a
> slightly different commit was pushed, coreutils' submodule SHA1 was
> invalid for a short interval.  However, I have pushed my local commit
> to the new gnulib branch named "coreutils-8.9".  With that, anyone
> cloning coreutils and trying to build from the 8.9 tag *will* get a
> usable gnulib hierarchy.
>
> Thanks to Eric Blake for noticing so quickly and for the suggestion
> to push my commit to a branch in gnulib.

I've included a patch, below, that should prevent recurrence.
I've made the new rule a dependent of "alpha beta stable",
so that it's only run at release time.

Obviously it'd be nice to do this for each and every submodule,
but for that, you'd need a URL for each of them, so I'm
keeping it simple for now.

Eventually I'll move it into maint.mk, where it will perform the test
only when gnulib is one of the submodules.

diff --git a/cfg.mk b/cfg.mk
index 4df74f0..0517201 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -337,3 +337,14 @@ include $(srcdir)/dist-check.mk
 update-copyright-env = \
   UPDATE_COPYRIGHT_USE_INTERVALS=1 \
   UPDATE_COPYRIGHT_MAX_LINE_LENGTH=79
+
+# Just before tagging a release, ensure that the gnulib submodule
+# commit we're using is public.
+alpha beta stable: gnulib-commit-check
+.PHONY: gnulib-commit-check
+gnulib-commit-check:
+       submod=gnulib; \
+       st=$$(git submodule status $$submod) || exit 1; \
+       commit=$$(echo $$st | awk '{ print $$1 }') || exit 1; \
+       wget -q -O /dev/null \
+         "http://git.savannah.gnu.org/gitweb/?p=$$submod.git;a=tree;h=$$commit";



reply via email to

[Prev in Thread] Current Thread [Next in Thread]