[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: update-copyright for non-FSF copyright notices?
From: |
Simon Josefsson |
Subject: |
Re: update-copyright for non-FSF copyright notices? |
Date: |
Sun, 02 Jan 2011 20:02:49 +0100 |
User-agent: |
Gnus/5.110011 (No Gnus v0.11) Emacs/23.2 (gnu/linux) |
Jim Meyering <address@hidden> writes:
> Simon Josefsson wrote:
>> How about this patch? Not all projects are copyright'ed by the FSF.
>> The patch makes it possible to override the otherwise hard-coded string,
>> thought cfg.mk and without modifying the update-copyright script iself.
>
> I like it.
> One suggestion before you push it:
...
>> -my $holder = 'Free Software Foundation, Inc.';
>> +my $holder = $ENV{UPDATE_COPYRIGHT_HOLDER};
>> +!$holder
>> + and $holder = 'Free Software Foundation, Inc.';
>
> In this case, I prefer to use this idiom; less duplication:
>
> $holder ||= 'Free Software Foundation, Inc.';
Thanks, that looks indeed better. I have pushed an updated version of
the patch.
/Simon
- update-copyright for non-FSF copyright notices?, Simon Josefsson, 2011/01/02
- Re: update-copyright for non-FSF copyright notices?, Jim Meyering, 2011/01/02
- Re: update-copyright for non-FSF copyright notices?,
Simon Josefsson <=
- Re: update-copyright for non-FSF copyright notices?, Bruce Korb, 2011/01/02
- Re: update-copyright for non-FSF copyright notices?, Simon Josefsson, 2011/01/02
- Re: update-copyright for non-FSF copyright notices?, Jim Meyering, 2011/01/03
- Re: update-copyright for non-FSF copyright notices?, Jim Meyering, 2011/01/03
- Re: update-copyright for non-FSF copyright notices?, Simon Josefsson, 2011/01/03