bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] nl_langinfo: fix YESEXPR on Irix 6.5


From: Bruno Haible
Subject: Re: [PATCH] nl_langinfo: fix YESEXPR on Irix 6.5
Date: Fri, 31 Dec 2010 22:15:11 +0100
User-agent: KMail/1.9.9

Hi Eric,

> diff --git a/lib/nl_langinfo.c b/lib/nl_langinfo.c
> index a3d0d11..a4bde12 100644
> --- a/lib/nl_langinfo.c
> +++ b/lib/nl_langinfo.c
> @@ -97,7 +97,7 @@ rpl_nl_langinfo (nl_item item)
>           strings, appended in memory.  */
>        return "\0\0\0\0\0\0\0\0\0\0";
>  # endif
> -# if GNULIB_defined_YESEXPR
> +# if GNULIB_defined_YESEXPR || !FUNC_NL_LANGINFO_YESEXPR_WORKS
>      case YESEXPR:
>        return "^[yY]";
>      case NOEXPR:

This part is OK.

> +         case "$host_os" in
> +                          # Guess no on irix systems.
> +           *-irix*)       gl_cv_func_nl_langinfo_yesexpr_works="guessing 
> no";;

Here replace   *-irix*   with   irix*
since you are testing "$host_os", not "$host".

> +    if test $HAVE_LANGINFO_CODESET = 1 && test $HAVE_LANGINFO_ERA = 1 \
> +      && test $FUNC_NL_LANGINFO_YESEXPR_WORKS = 1; then
>        :

Here add one more space of indentation before &&, please.

> I guess I should also update docs/posix-functions/nl_langinfo.texi.

Yes, please.

Bruno



reply via email to

[Prev in Thread] Current Thread [Next in Thread]