bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] pipe: make obsoletion transition easier


From: Eric Blake
Subject: [PATCH] pipe: make obsoletion transition easier
Date: Fri, 24 Dec 2010 13:30:48 -0700

* lib/pipe.h: Restore file as thin shim around "spawn-pipe.h".
* modules/pipe (Files): Include revived file.
(Include): Drop reference, to mirror getdate's behavior.

Signed-off-by: Eric Blake <address@hidden>
---

> Since at this point we are not considering moving either all POSIX
> related modules or all application-level modules to a new naming
> convention, I think it's best to rename the application-level module 'pipe'
> at this point.

Thanks for doing that, again.

> In a second step, in a couple of months, we'll be able to remove the
> module 'pipe' without much damage.

I just update m4.git to the latest gnulib, and it failed to compile
because it was expecting the old "pipe.h".  This patch mirrors what
is done by the getdate transition module, by keeping the old name
around until such time as packages have swapped to the new module.

Therefore, I don't think we're quite at the point of removing the pipe
module, yet.

> In a third step, later again, you can then rename 'pipe-posix' to 'pipe'.

But yes, these three steps do sound appropriate.


 ChangeLog    |    7 +++++++
 lib/pipe.h   |    2 ++
 modules/pipe |    2 +-
 3 files changed, 10 insertions(+), 1 deletions(-)
 create mode 100644 lib/pipe.h

diff --git a/ChangeLog b/ChangeLog
index 9947f1f..28d6819 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2010-12-24  Eric Blake  <address@hidden>
+
+       pipe: make obsoletion transition easier
+       * lib/pipe.h: Restore file as thin shim around "spawn-pipe.h".
+       * modules/pipe (Files): Include revived file.
+       (Include): Drop reference, to mirror getdate's behavior.
+
 2010-12-24  Bruno Haible  <address@hidden>

        sys_socket: Hide mismatch of declarations on NonStop Kernel.
diff --git a/lib/pipe.h b/lib/pipe.h
new file mode 100644
index 0000000..3c1b4b8
--- /dev/null
+++ b/lib/pipe.h
@@ -0,0 +1,2 @@
+/* Obsolete; consider using spawn-pipe.h instead.  */
+#include "spawn-pipe.h"
diff --git a/modules/pipe b/modules/pipe
index 3d6ccee..06e0706 100644
--- a/modules/pipe
+++ b/modules/pipe
@@ -8,6 +8,7 @@ Notice:
 This module is obsolete. Use the module 'spawn-pipe' instead.

 Files:
+lib/pipe.h

 Depends-on:
 spawn-pipe
@@ -17,7 +18,6 @@ configure.ac:
 Makefile.am:

 Include:
-"spawn-pipe.h"

 License:
 GPL
-- 
1.7.3.4




reply via email to

[Prev in Thread] Current Thread [Next in Thread]