[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [libvirt] [PATCH] show compiled in options in virsh --version
|
From: |
Eric Blake |
|
Subject: |
Re: [libvirt] [PATCH] show compiled in options in virsh --version |
|
Date: |
Thu, 28 Oct 2010 13:31:53 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100921 Fedora/3.1.4-1.fc13 Mnenhy/0.8.3 Thunderbird/3.1.4 |
[adding bug-gnulib]
On 10/28/2010 01:25 PM, Daniel Veillard wrote:
>>> case 'v':
>>> - /* FIXME - list a copyright blurb, as in GNU programs? */
>>> - puts(VERSION);
>>> + vshShowVersion(ctl);
>>> exit(EXIT_SUCCESS);
>>
>> Pre-existing bug - we don't detect write failure to stdout to exit with
>> non-zero status. Unchanged by your patch.
>
> Not sure it's really a problem, but okay I will look.
The gnulib module closeout can automatically take care of this, but it
is currently licensed as GPL. Jim, Bruno, are you okay with relicensing
closeout and close-stream as LGPLv2+?
--
Eric Blake address@hidden +1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [libvirt] [PATCH] show compiled in options in virsh --version,
Eric Blake <=