|
From: | Eric Blake |
Subject: | Re: [PATCH] renameat: port to Solaris 10, which declares renameat in unistd.h |
Date: | Tue, 26 Oct 2010 17:24:20 -0600 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100921 Fedora/3.1.4-1.fc13 Mnenhy/0.8.3 Thunderbird/3.1.4 |
On 10/26/2010 05:15 PM, Bruno Haible wrote:
Yes, but we can limit the damage to Solaris systems and to packages that use the 'renameat' module. Like we do in lib/string.in.h for example. Here's a proposed patch. I verified that it fixes the compilation error mentioned above. It also mentions the Solaris problem in the documentation (like we do for all portability problems, regardless whether we add a workaround to gnulib).
I concur with the idea of this patch, but wonder if we need to tighten up lib/unistd.in.h to only include <stdio.h> on Cygwin, so as to avoid difficult analysis of whether the circular inclusions between our replacement <stdio.h> and <unistd.h> would negatively affect Solaris 10.
-- Eric Blake address@hidden +1-801-349-2682 Libvirt virtualization library http://libvirt.org
[Prev in Thread] | Current Thread | [Next in Thread] |