[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/7] contents of topic/libposix for merge to master
|
From: |
Gary V. Vaughan |
|
Subject: |
Re: [PATCH 0/7] contents of topic/libposix for merge to master |
|
Date: |
Wed, 13 Oct 2010 16:30:42 +0700 |
On 13 Oct 2010, at 03:03, Bruno Haible wrote:
> Hi Gary,
Hallo Bruno,
>> This patch series is what I've just pushed as a new topic branch to
>> the savannah repo.
>
> Wow! You're fast. I love your initiative and appreciate your approach.
Thanks. And thanks also for the fast responses.
>> Okay to merge to master?
>
> Not so fast. We need to digest and check each of the patches one by one.
Heh, can't blame me for trying though :-)
> There's also a technical problem: Jim decided that in gnulib's git repository,
> merge commits are disallowed. I don't remeember the rationale, but I think it
> is a good decision, because
> 1. it assigns a clear responsibility to every committer to respect all
> previous commits,
> 2. it allows to define a natural order of ChangeLog entries in ChangeLog.
> As a side effect, it makes topic branches pretty useless. But that's not a
> big problem. I can use "git format-patch" followed by "git am" to copy your
> commits to HEAD.
Also, I think git cherry-pick doesn't link the merge step in the repo and
requires less fuss to work within the no-merge-commits rule.
>> Distcheck results by architecture and compiler:
>>
>> dec Tru64 5.1 Compaq C 6.5 (mbrlen.c compile failed:
>> rpl_mbstate_t has no linkage and a prior
>> declaration in scope at 415:./wchar.h)
>> gcc 4.2.4 (areadlink.c compile failed:
>> conflicting types for rpl_mbstate_t
>> conflicting types for rpl_mbsinit
>> ..etc)
>> hppa HPUX 10.20 hpcc 10.32 (fdopendir.c compile failed:
>> 153: unexpected symbol struct
>> 153: saved_cwd undefined
>> 154: argument #1 incorrect type)
>> gcc 4.2.4 (pt_chown link failed:
>> can't open pt_chown.o)
>> hppa HPUX 11.00 hpcc B.11.11 (test-getlogin_r.c compile failed:
>> 24: identifier getlogin_r undefined)
>> gcc 4.2.4 (pt_chown link failed:
>> can't open pt_chown.o)
>> hppa HPUX 11.11 hpcc B.11.11 (test-getlogin_r.c compile failed:
>> 24: identifier getlogin_r undefined)
>> gcc 4.2.4 (pt_chown link failed:
>> can't open pt_chown.o)
>> hppa HPUX 11.23 hpcc B.11.11 (test-getlogin_r.c compile failed:
>> 24: identifier getlogin_r undefined)
>> gcc 4.2.4 (pt_chown link failed:
>> can't open pt_chown.o)
>> hppa HPUX 11.31 hpcc B.11.11 (test-stdbool.c compile failed:
>> 65: object size too small for an
>> address)
>> gcc 4.2.4 (pt_chown link failed:
>> can't open pt_chown.o)
>> ia64 HPUX 11.23 hp acc A.06.25 (test-getlogin_r.c compile failed:
>> 24: identifier getlogin_r undefined)
>> gcc 4.2.4 (test-fcntl-h-c++ link failed:
>> ./unistd.h:1011 ::getlogin_r undeclared
>> ./unistd.h:1528 ::tyname_r undeclared)
>> ia64 HPUX 11.31 hp acc A.06.25 (dprintf-posix2.sh, fprintf-posix2.sh,
>> fprintf-posix3.sh, getlogin_r, iconv,
>> mkdir, mkdirat, poll, pread.sh,
>> printf-posix2.sh, ptsname, remove,
>> strtod)
>> gcc 4.2.4 (pt_chown link failed:
>> can't open pt_chown.o)
>> ix86 MacOS 10.6.4 gcc 4.2.1 (317 tests passed)
>> ix86 RHEL 3 gcc 3.2.3 (317 tests passed)
>> ix86 RHEL 4 gcc 3.4.6 (test-fcntl-h-c++.cc compile failed:
>> 133: symbol `mknod' already defined)
>> ix86 RHEL 5 gcc 4.1.2 (rename, renameat)
>> ix86 Solaris 10 Sun Studio 12 (poll, ptsname)
>> gcc 4.2.4 (getlogin, getlogin_r, poll, ptsname)
>> ix86 SLED 10 gcc 4.1.2 (fchownat, rename, renameat)
>> mips IRIX 6.5 MIPSpro 7.4.4 (mbsnrtowcs.c compile failed:
>> wchar.h:601: mbstate_t undefined
>> /usr/include/internal/wchar_core.h:
>> pragma usage incorrect
>> #pragma optional wcrtomb
>> /usr/include/stdint.h:
>> incompatible SIZE_MAX redefinition
>> (declared at 2885:../config.h)
>> /usr/include/stdint.h:
>> incompatible WCHAR_MIN redefinition
>> (declared at
>> /usr/include/internal/wchar_core.h)
>> /usr/include/stdint.h:
>> incompatible WCHAR_MAX redefinition
>> (declared at
>> /usr/include/internal/wchar_core.h)
>> )
>> gcc 4.2.4 (mbsnrtowcs.c compile failed:
>> ./wchar.h:601 expected declaration
>> before mbstate_t
>> ./wchar.h:627 expected declaration
>> before mbstate_t
>> ./wchar.h:694 expected declaration
>> before mbstate_t
>> /usr/include/internal/wchar_core.h:
>> conflicting types for rpl_wcrtomb)
>> ppc AIX 5.1 xlc 8.0/rtl (test-isinf.c compile failed:
>> 26: $error missing declaration
>> 56: divisor cannot be zero
>> 57: divisor cannot be zero
>> 102: divisor cannot be zero
>> 103: divisor cannot be zero
>> 151: divisor cannot be zero
>> 152: divisor cannot be zero)
>> gcc 4.2.4 (fcntl.c compile failed:
>> 170: implicit declaration of va_start
>> 202: implicit declaration of va_arg
>> 292: implicit declaration of va_end)
>> ppc AIX 5.2 xlc 8.0/rtl (test-sys_socket.c compile failed:
>> 52: ss_family is not a member of struct
>> sockaddr_storage)
>> gcc 4.2.4 (test-sys_socket.c compile failed:
>> 52: struct sockadr_storage has no
>> member 'ss_family')
>> ppc AIX 5.3 xlc 8.0/rtl (270 failures all similar to this:
>> rtld: iconv was referenced, but a
>> runtime definition was not found
>> rtld: iconv_close was referenced, but a
>> runtime definition was not found
>> rtld: iconv_open was referenced, but a
>> runtime definition was not found)
>> gcc 4.2.4 (test-fcntl-h-c++ compile faild:
>> ./unistd.h:887 invalid conversion from
>> 'int (*)(...)' to 'int (*)()')
>> ppc AIX 6.1 xlc 10.1/rtl (270 failures all similar to this:
>> rtld: iconv was referenced, but a
>> runtime definition was not found
>> rtld: iconv_close was referenced, but a
>> runtime definition was not found
>> rtld: iconv_open was referenced, but a
>> runtime definition was not found)
>> gcc 4.2.4 (test-fcntl-h-c++ compile faild:
>> ./unistd.h:887 invalid conversion from
>> 'int (*)(...)' to 'int (*)()')
>> sparc Solaris 2.6 Sun Workshop 6 (fdopendir.c compile failed:
>> 153: syntax error before struct
>> 154: undefined symbol: saved_cwd
>> 154: argument #1 incompatible with
>> prototype)
>> gcc 4.2.4 (pt_chown link failed:
>> can't open pt_chown.o)
>> sparc Solaris 7 Sun Studio 8 (mbsnrtowcs2.sh, mbsrtowcs2.sh,
>> poll, ptsname)
>> gcc 4.2.4 (pt_chown link failed:
>> can't open pt_chown.o)
>> sparc Solaris 8 gcc 4.2.4 (test-isnan.c compile failed:
>> 26: #error missing declaration)
>> sparc Solaris 9 Sun Studio 12 (poll, ptsname)
>> gcc 4.2.4 (test-isnan.c compile failed:
>> 26: #error missing declaration)
>> sparc Solaris 10 Sun Studio 12 (poll, ptsname)
>> gcc 4.2.4 (test-isnan.c compile failed:
>> 26: #error missing declaration)
>> x86_64 RHEL 3 gcc 3.2.3 (fprintf-posix2.sh)
>> x86_64 RHEL 4i gcc 3.4.6 (test-fcntl-h-c++.cc compile failed:
>> 124: symbol `mknod' already defined
>> 149: symbol `lstat' already defined
>> 172: symbol `fstat' already defined)
>> x86_64 RHEL 5 gcc 4.1.2 (dprintf-posix2.sh, fprintf-posix3.sh
>> rename, renameat)
>> x86_64 SLED 10 gcc 4.1.2 (rename, renameat)
>
> Pheew. These can be the topics of multiple threads that will keep us busy for
> two weeks. Thanks for mentioning all these.
I've kept all the build logs, so feel free to start new threads for anything
that requires more detail or further testing to track down. Arguably,
libposix is not terribly useful if it doesn't work on a wide range of
architectures... although it certainly makes it easier to test a useful
subset of features.
Cheers,
--
Gary V. Vaughan (address@hidden)
PGP.sig
Description: This is a digitally signed message part